search

fermyon / spin-dotnet-sdk

Apache License 2.0
43 stars 11 forks source link

Fix hyphens in project name being included in namespace #40

Closed itowlson closed 1 year ago

itowlson commented 2 years ago

Fixes #36.

See the tests in tools/dotted-pascal-case-filter/src/lib.rs for the resulting behaviour.

NOTE: Requires a Spin build with https://github.com/fermyon/spin/pull/761 - do not merge until that's released.

mikkelhegn commented 2 years ago

@itowlson - is the plan to merge this with the 0.6.0 release?

itowlson commented 2 years ago

@mikkelhegn It depends on an 0.6 feature. Though we could merge it now and use a tag so it doesn't get picked up by 0.5 installers.

mikkelhegn commented 1 year ago

Is this good to be merged, now that we have 0.6.0 out?

itowlson commented 1 year ago

It is! Thanks for the reminder.