search

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components
Apache License 2.0
52 stars 18 forks source link

Outdated quickjs-wasm-sys dependency triggering clang-16 bug #186

Closed chrismatteson closed 1 month ago

chrismatteson commented 1 year ago

spin-js-engine is pinned to quickjs-wasm-sys 0.1.2 while the current version is 1.1.2. quickjs-wasm-sys is pinned to bindgen 0.59.2 which has a bug with clang-16 that was fixed in this pr that was released in bindgen 0.62.

We should upgrade quickjs-wasm-sys if possible to resolve this issue.

chrismatteson commented 1 year ago

Specifically this is what the error that the above causes looks like when running make against llvm 16.0.6 on a MacBook m2:

  --- stderr
  thread 'main' panicked at '"enum_(unnamed_at__/quickjs/quickjs_h_67_1)" is not a valid Ident', /Users/chrismatteson/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.66/src/fallback.rs:774:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
make: *** [target/wasm32-wasi/release/spin-js-engine.wasm] Error 101
radu-matei commented 1 year ago

Our CI pins WASI SDK v16, which relies on LLVM14. We should either update them to track the latest, or document the requirement.

https://github.com/fermyon/spin-js-sdk/blob/main/.github/workflows/test.yaml#L53

redoC-A2k commented 4 months ago

I am getting same error , even though I have installd wasi-sdk v16 and moved the content of extracted folder into /opt/wasi-sdk. Could you please help me ?

karthik2804 commented 1 month ago

We now have a newer version of the SDK that uses ComponentizeJS