search

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components
Apache License 2.0
54 stars 18 forks source link

Add missing SDK features #19

Closed dicej closed 1 year ago

dicej commented 2 years ago

(TODO: add more as we think of them)

karthik2804 commented 2 years ago

For the minimal implementation of fsPromise.readDir, can we assume that filenames will always be returned as utf-8? Also, do we need to support the withFileTypes argument?

dicej commented 2 years ago

For the minimal implementation of fsPromise.readDir, can we assume that filenames will always be returned as utf-8?

In general, we can't assume they'll be UTF-8, but for the time being it's reasonable to only support UTF-8 file and directory names. If that limitation causes problems for people, we can address it later.

Also, do we need to support the withFileTypes argument?

Again, I think we can live without it to start with and add it later if people (or popular libraries) need it.