search

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components
Apache License 2.0
49 stars 17 forks source link

Windows mkdir fix #214

Closed oferh closed 8 months ago

oferh commented 8 months ago

fix for #209 replace mkdir -p with the mkdirp package

dicej commented 8 months ago

Looks great -- thanks for this, @oferh! Would you mind signing your commit? We have a branch rule set up that requires commits to be signed prior to merging.

karthik2804 commented 8 months ago

This is great! Thanks. I think the examples will also need the same change. I can update the examples as a follow-up.

oferh commented 8 months ago

@dicej signed the commit. @karthik2804 - added fix for examples and test