Why is `InferenceResult` not exported ?

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components

Apache License 2.0

49 stars 17 forks source link

Open sebastienblanc opened 7 months ago

sebastienblanc commented 7 months ago

Looking here : https://github.com/fermyon/spin-js-sdk/blob/main/spin-sdk/src/modules/spinSdk.ts#L314 I can see that InferenceResult(and some others like InferenceUsage) are not exported . Any reasons for this ?

itowlson commented 7 months ago

Oddly enough they do appear in the docs (https://fermyon.github.io/spin-js-sdk/variables/Llm.html links to https://fermyon.github.io/spin-js-sdk/interfaces/_internal_.InferenceResult.html) although under an "internal" grouping. @karthik2804 @dicej any idea what the intention is here?

karthik2804 commented 7 months ago

I think that was just an oversight and it should be exported.