search

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components
Apache License 2.0
49 stars 17 forks source link

[feat/sdk-v2]: test application does not use local SDK #245

Closed radu-matei closed 1 month ago

radu-matei commented 1 month ago

The test script that is run on PRs on the feat/sdk-v2 branch is using the published version of the SDK, meaning we don't actually test changes to the SDK on GH Action runs.

We should update the SDK dependency to point to the local SDK.

radu-matei commented 1 month ago

Because of the above, the test app is currently not building with the latest version of the SDK.

karthik2804 commented 1 month ago

Updated in https://github.com/fermyon/spin-js-sdk/pull/244/commits/86eff5bac64da7b6d96c7f9d0f01003a9d4f7d7c

karthik2804 commented 1 month ago

This has now been fixed.