search

fermyon / spin-js-sdk

https://developer.fermyon.com/spin/javascript-components
Apache License 2.0
52 stars 18 forks source link

Rename NPM package to `@fermyon/spin-sdk` #59

Closed radu-matei closed 1 year ago

radu-matei commented 1 year ago

This way, when importing, it would go from

import { HandleRequest, HttpResponse} from "@fermyon/spin-sdk-types"

to

import { HandleRequest, HttpResponse} from "@fermyon/spin-sdk"

Additionally, we might want to extend the SDK to include other things, not just types.

karthik2804 commented 1 year ago

This package is meant only to add TypeScript support as any implementation added will be a part of the binary published as Spin plugin.

radu-matei commented 1 year ago

Right — but this is the public package someone brings in when they want to create a Spin application — and there is a discrepancy between all other SDKs (which are spin-sdk or spin_sdk) and this one.

karthik2804 commented 1 year ago

That makes sense. Should I go ahead and change the name of the package? @radu-matei

karthik2804 commented 1 year ago

The package has been renamed. I will make a follow-up PR to adjust the templates and the examples.