search

fermyon / spin

Spin is the open source developer tool for building and running serverless applications powered by WebAssembly.
https://developer.fermyon.com/spin
Apache License 2.0
5.21k stars 247 forks source link

CI: Automated templates tag push may not run #1302

Open vdice opened 1 year ago

vdice commented 1 year ago

Currently we have automation around pushing a template tag (eg spin/templates/v1.0) for each new Spin release.

However, it depends on the automated sdk bump PR be merged specifically via a merge commit. If merged via another approach, say via rebase, the automation won't run, as it relies on data only present on a merge commit event (eg github.event.commits[0].author.name == 'fermybot').

We should improve the robustness of this automation so it will run as intended regardless of how the sdk bump PR is merged into main.

vdice commented 1 year ago

Workaround until this is fixed:

Merge fermybot's PR via a merge commit specifically (i.e. continue to follow the note here: https://github.com/fermyon/spin/blob/main/docs/content/release-process.md?plain=1#L69)