fermyon / spin

Spin is the open source developer tool for building and running serverless applications powered by WebAssembly.
https://developer.fermyon.com/spin
Apache License 2.0
5.17k stars 247 forks source link

Non-maintainers can't assign reviewers to their PRs #2804

Open calebschoepp opened 3 weeks ago

calebschoepp commented 3 weeks ago

With the recent governance change non-maintainers have lost the ability to assign reviewers to their PRs. I've found this to be unergonomic because now I have to revert to pinging people in comments to get them to review my code.

michelleN commented 3 weeks ago

Would it be helpful to automatically assign reviewers to PRs to resolve this issue? or do you want to be able to assign specific reviewers?

calebschoepp commented 3 weeks ago

I think auto assigned reviewers is helpful sometimes. But, I can also think of a lot of scenarios where I have a specific person or two in mind and would just want to be able to assign them.

Two questions I think we should ask ourselves:

lann commented 3 weeks ago

Perhaps we could have a "contributors" group with triage permissions and add anyone who has made "signficant contributions" to the project? Triage is pretty limited and would only be a problem if applied to someone malicious or spammy.

lann commented 1 week ago

It appears that you cannot have teams contain members that aren't also org members but we could still maintain a flat list of triagers in the repo.