search

fernandoandreotti / fecgsyn

FECGSYN toolbox for ECG and fetal ECG simulation
http://www.fecgsyn.com/
GNU General Public License v3.0
80 stars 26 forks source link

add_noisedipole with octave #45

Closed ericqu closed 5 years ago

ericqu commented 5 years ago

While using octave, and following the section "Initial NI-FECG simulation example" from the getting started webpage I encountered an error stating that the pca function is missing in the statistics package.

I noted that there is a "princomp" function in the package, and changed the line 166 from [~,pc] = pca(noise_ar); to [~,pc] = princomp(noise_ar);

It resolved the issue, however I am new to octave/matlab, so I am not 100% sure that the function are interchangeable. Could someone kindly indicate that this change is making sense?

fernandoandreotti commented 5 years ago

Hi @ericqu, Matlab has removed princomp function on 2019a. Instead it suggests using pca. Your change makes sense to me.

Sorry for this conflict, I have pushed the following PR https://github.com/fernandoandreotti/fecgsyn/pull/47 and will check if it runs smoothly.

ericqu commented 5 years ago

thanks