Crate r2d2 build fixed

[fernandobatels]

Fixed the release build of r2d2_firebird crate. Now we have a phantom option on simple connection/transaction enum's.

Without this fix, we cannot build the r2d2 on release mode.

Issue #125

[coveralls]

Pull Request Test Coverage Report for Build 2757615272

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 7 of 17 (41.18%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on r2d2fix at 82.398%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/connection/simple.rs	5	6	83.33%
src/transaction/simple.rs	2	11	18.18%
<!--	Total:	7	17	41.18%	-->

Totals
Change from base Build 2750544977:	82.4%
Covered Lines:	3127
Relevant Lines:	3795

---

💛 - Coveralls

[jairinhohw]

I don't understand the problem, the crate can be built as long as one of the 3 main rsfbclient features are enables (linking, dynamic_loading, or pure_rust). If we merge this, it will allways pull the pure_rust implementation, even if not necessary (using linking for example).

[fernandobatels]

I don't understand the problem, the crate can be built as long as one of the 3 main rsfbclient features are enables (linking, dynamic_loading, or pure_rust). If we merge this, it will allways pull the pure_rust implementation, even if not necessary (using linking for example).

On master branch, running cargo build --release inside rd2d_firebird:

error[E0392]: parameter `'c` is never used
  --> src/transaction/simple.rs:19:30
   |
19 | pub struct SimpleTransaction<'c> {
   |                              ^^ unused parameter

The cargo publish build the crate on release mode. Without my fix, I cannot launch new versions of rd2d.

I agree with your commentary about always pull the pure_rust. I will find an alternative.

[jairinhohw]

Does it work if you do cargo publish --features rsfbclient/pure_rust ?

[fernandobatels]

cargo publish --features rsfbclient/pure_rust

It worked. Thanks. This PR is no longer needed.