Update to diesel 2.0.0-rc.1

weiznich commented 2 years ago

This currently requires an additional patch for overwriting the QueryFragment impl for SelectStatement. I will work on submitting a PR for upstreaming this soon.

This only updates the implementation, not the tests yet. That needs to be done by someone that is more familiar with the firebird database system.

fernandobatels commented 2 years ago

Thanks for your contribution. I was already studying the diesel rc to fix out implementation, your work will help a lot.

That needs to be done by someone that is more familiar with the firebird database system.

Don’t worry, I got this.

weiznich commented 2 years ago

Don’t worry, I got this.

That would be great. Just let me know if there is something unclear form diesels side.

fernandobatels commented 2 years ago

Todo:

[x] fix tests connection
[x] fix tests crud
[x] fix tests query
[x] fix tests types
[x] check the diesel re-export
[ ] wait for diesel-rs/diesel#3257 and update the reference
[x] revert the commit 873b948667840ac27c549444f5180351d9ea1288
[x] check all ToSql and FromSql types

fernandobatels commented 2 years ago

That would be great. Just let me know if there is something unclear form diesels side.

Can you tell me what I'm missing?

error[E0275]: overflow evaluating the requirement `_: Sized`
    --> rsfbclient-diesel/src/tests/crud.rs:21:10
     |
21   |         .execute(conn)
     |          ^^^^^^^
     |
     = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`rsfbclient_diesel`)

I already changed the recursion_limit, but without effect. I'm currently checking the implementation of the others backends.

fernandobatels commented 2 years ago

That would be great. Just let me know if there is something unclear form diesels side.

Can you tell me what I'm missing?
error[E0275]: overflow evaluating the requirement `_: Sized`
    --> rsfbclient-diesel/src/tests/crud.rs:21:10
     |
21   |         .execute(conn)
     |          ^^^^^^^
     |
     = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`rsfbclient_diesel`)
I already changed the recursion_limit, but without effect. I'm currently checking the implementation of the others backends.

ToSql of i32 and i64 missing. Solved.

weiznich commented 2 years ago

ToSql of i32 and i64 missing

Other ToSql impls are likely missing as well. Diesel does not provide any of these impls by default anymore.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2793438648

179 of 246 (72.76%) changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.656%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rsfbclient-diesel/src/fb/value.rs	0	1	0.0%
rsfbclient-diesel/src/tests/crud.rs	23	25	92.0%
rsfbclient-diesel/src/tests/types.rs	21	24	87.5%
rsfbclient-diesel/src/fb/types.rs	24	29	82.76%
rsfbclient-diesel/src/fb/connection.rs	16	23	69.57%
rsfbclient-diesel/src/tests/connection.rs	12	19	63.16%
rsfbclient-diesel/src/fb/query_builder.rs	15	26	57.69%
rsfbclient-diesel/src/fb/transaction.rs	27	58	46.55%
<!--	Total:	179	246	72.76%	-->

Totals
Change from base Build 2750544977:	0%
Covered Lines:	1675
Relevant Lines:	3181

💛 - Coveralls

fernandobatels commented 2 years ago

I will wait for diesel-rs/diesel#3257, but this PR is ready for review

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 2788900510

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

177 of 244 (72.54%) changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on diesel_update at 84.743%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rsfbclient-diesel/src/fb/value.rs	0	1	0.0%
rsfbclient-diesel/src/tests/crud.rs	23	25	92.0%
rsfbclient-diesel/src/tests/types.rs	21	24	87.5%
rsfbclient-diesel/src/fb/types.rs	24	29	82.76%
rsfbclient-diesel/src/fb/connection.rs	16	23	69.57%
rsfbclient-diesel/src/tests/connection.rs	12	19	63.16%
rsfbclient-diesel/src/fb/query_builder.rs	13	24	54.17%
rsfbclient-diesel/src/fb/transaction.rs	27	58	46.55%
<!--	Total:	177	244	72.54%	-->

Totals
Change from base Build 2750544977:	84.7%
Covered Lines:	3688
Relevant Lines:	4352

fernandobatels / rsfbclient