search

fernandobatels / rsfbclient

Rust Firebird Client
MIT License
76 stars 11 forks source link

Minimized use of unsafe and a bit of changes to the api #4

Closed jairinhohw closed 4 years ago

jairinhohw commented 4 years ago

I've also changed some of the types in the ibase module back to the originals generated by bindgen, i think it's better to not change the autogenerated code to simplify moving to newer versions of the fbclient, and the module could be autogenerated if we can make static linking work, what do you think?

fernandobatels commented 4 years ago

I've also changed some of the types in the ibase module back to the originals generated by bindgen, i think it's better to not change the autogenerated code to simplify moving to newer versions of the fbclient, and the module could be autogenerated if we can make static linking work, what do you think?

I agree. I will make a small changes in the error.rs and the examples, but the PR are OK and we can accept then