fernandobatels / rsfbclient

Rust Firebird Client
MIT License
76 stars 11 forks source link

doc and identifier modifications #81

Closed dancingbug closed 4 years ago

dancingbug commented 4 years ago

Is what I said about Option<T> on IntoParams correct?

Please additionally add a doc comment for the derive macro, especially since it is referenced in params.rs and now query.rs docs.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 307653164


Files with Coverage Reduction New Missed Lines %
src/transaction.rs 1 54.26%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 305570092: 0.0%
Covered Lines: 2306
Relevant Lines: 2981

💛 - Coveralls
fernandobatels commented 4 years ago

Is what I said about Option<T> on IntoParams correct?

Yes

fernandobatels commented 4 years ago

Please additionally add a doc comment for the derive macro, especially since it is referenced in params.rs and now query.rs docs.

I pushed a commit fixing this. Do you can review?

dancingbug commented 4 years ago

Please additionally add a doc comment for the derive macro, especially since it is referenced in params.rs and now query.rs docs.

I pushed a commit fixing this. Do you can review?

:+1: thanks.

I edited and expanded it a little bit

Go ahead and merge this to your PR if you're satisfied