Support aws-sdk version3

fernandocarletti / capistrano-aws

Integrates Capistrano with AWS EC2.

MIT License

16 stars 6 forks source link

Support aws-sdk version3 #1

Closed allaire closed 6 years ago

allaire commented 6 years ago

Hi,

Could we bump the dependency to aws-sdk or there are some breaking changes preventing this?

Thank you for your work on this gem by the way!

allaire commented 6 years ago

@fernandocarletti Also with aws-sdk v3, I think we could only have dependency for the ec2 gem, since they split the library 👍

fernandocarletti commented 6 years ago

Hello @allaire. I don't think we will have any issue updating it. If you can work on this right now, let me know then I merge your PR ASAP. Otherwise, I'll check this during this week. Maybe it would be good to just bump a minor version in this lib, just in case.

allaire commented 6 years ago

@fernandocarletti I just tested it and was able to correctly call cap staging aws:ec2:instances using aws-sdk v3

fernandocarletti commented 6 years ago

Awesome! Just send the PR so I can make the release. Thank you!

allaire commented 6 years ago

On it

On Mon, Mar 26, 2018 at 4:11 PM, Fernando Carlétti <notifications@github.com

wrote:

Awesome! Just send the PR so I can make the release. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fernandocarletti/capistrano-aws/issues/1#issuecomment-376295934, or mute the thread https://github.com/notifications/unsubscribe-auth/AASlTWELqtmr0mxb-Znp57HV5s8BOcUSks5tiUt_gaJpZM4S70QE .

-- Mathieu Allaire http://www.mathieuallaire.ca