search

fernandokosh / redmine_time_tracker

A time tracker plugin for Redmine
Other
203 stars 141 forks source link

Time Tracker popup extension #35

Closed pulse00 closed 13 years ago

pulse00 commented 13 years ago

Hi,

i've extended your time tracking plugin with a popup time-tracker.

The features are:

I'm new to ruby/rails programming, so if you're interested in the extension, you might pull it into a separate branch, as i strongly suggest that the code of the extension should be reviewed by someone with more experience before merging it into master.

delaitre commented 13 years ago

Thanks a lot for the patch. I've not tested it yet but I will as soon as time permits.

delaitre commented 13 years ago

I've tried to test this feature without success. A quick look at the source seems to indicate that a link in the account menu allows to open the popup, but nothing appears here (tried with an old redmine 1.0.2). I've found nothing to open the popup.

Could you explain me what should I see?

Another problem I saw is that your patch set is relatively big and I have no much time to maintain the plugin. Thus, including your work could be difficult for me to maintain it afterward.

This is my current though, however as I can't test the feature (I'm not sure what it really does) I can't take a final decision.

Bonus: rebasing your work on the current master will be a plus

that0n3guy commented 13 years ago

I just tested this. It does work but needs to be updated. Here is a screenshot with some explanation text:

http://img560.imageshack.us/i/redminetimetrackerpopou.png/

delaitre commented 13 years ago

Ok, I see what is this now...however I don't understand why it's really useful? Does the main feature is to be able to select multiple issue to work on and then start/stop the time tracking on them easily? If this is the case, it should/will be implemented in the "time tracker lists page of the last plugin version.

that0n3guy commented 13 years ago

I don't know if you can work on multiple issues, I didnt test that. The only thing its really useful for is that you don't have to leave the page your on in redmine, which is nice. I got rid of it though because I like the new version w/ the play/pause/stop buttons.

I'd rather have the "not running" text be a link that does something similar but with a jquery/modalframe popup. That way you still don't have to leave the page your on (like a wiki page, or forum) to start working on an issue.

delaitre commented 13 years ago

Ok, I got it!

I'm often in the same situation and here is how I manage to start a time tracker in this situation:

I think this is not too cumbersome to do it that way. Moreover, as you no more use your extension, I'll not merge it. This is too much work to maintain.

Thanks again for the work you've done.

On Thu, Apr 28, 2011 at 4:16 PM, that0n3guy < reply@reply.github.com>wrote:

I don't know if you can work on multiple issues, I didnt test that. The only thing its really useful for is that you don't have to leave the page your on in redmine, which is nice. I got rid of it though because I like the new version w/ the play/pause/stop buttons.

I'd rather have the "not running" text be a link that does something similar but with a jquery/modalframe popup. That way you still don't have to leave the page your on (like a wiki page, or forum) to start working on an issue.

Reply to this email directly or view it on GitHub:

https://github.com/delaitre/redmine_time_tracker/pull/35#issuecomment-1069979

that0n3guy commented 13 years ago

Thats the way I handle it as well. After a while I find myself with 10 tabs open though :). But thats probably a personal issue, ha.

Oh, and I'm not the creator of that extension. I'm just a random tester. But I probably wouldn't merge it as well unless the author has some other significant changes to the extension.

pulse00 commented 13 years ago

Sorry for not answering so long, i had a lot to of work to do in the last few weeks. I can understand that it's too much work for you to maintain the patch. As i'm not sure if i have the time to keep maintaining the extension in the future, it'll probably be better that way.