fernandokosh / redmine_time_tracker

A time tracker plugin for Redmine
Other
203 stars 141 forks source link

Installation process bug -- Can enable "log time" before the module is installed #83

Open carlcrott opened 11 years ago

carlcrott commented 11 years ago

I'm not sure if this has been patched ... if not I could possibly contribute!

https://github.com/delaitre/redmine_time_tracker/#install

Essentially Step 4 can be run before the migrations are added ( thus causing errors in redmine causing the system to 500 ) ... I'm thinking that this would be a really simple fix to just test if the module is defined ... if so: display the option for "log time"

Also I'd like to add a note to the README to tell the user where these permissions can be activated.

delaitre commented 11 years ago

I don't see what is the benefit of doing the step 4 before the migration and what is "the option for log time". Could you explain a bit more precisely?

carlcrott commented 11 years ago

There is no advantage to doing step 4 before the migration ... =] it breaks things ... what I'm proposing is to verify that the migration has been run BEFORE the user can perform step 4.

sequentially (1..2..3..4..5..6) everything works ... but a user can activate step 4: "Setup the ‘log time’ permissions for your roles"

before the migrations and thus they break their redmine installation