search

fernandreu / office-ribbonx-editor

An overhauled fork of the original Custom UI Editor for Microsoft Office, built with WPF
MIT License
528 stars 104 forks source link

id and isMso on the same line accepted #114

Closed GimmeChowder closed 4 years ago

GimmeChowder commented 4 years ago

Validate did not catch this line:

fernandreu commented 4 years ago

I think the problem might be that, with both attributes present, it is still correct in terms of the XML Schema (which is what it is being validated against), but Excel might apply some extra validation. I'll see what I can do.

GimmeChowder commented 4 years ago

No problem. I'm just trying to be a good user and report what I see.

Thanks,

Al Sim Web Project Manager ValuSource

On 10/22/2020 1:02 PM, Fernando Andreu wrote:

I think the problem might be that, with both attributes present, it is still correct in terms of the XML Schema (which is what it is being validated against), but Excel might apply some extra validation. I'll see what I can do.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/114#issuecomment-714698166, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARO3RREGLBBSVPHSJWLRQL3SMB6VFANCNFSM4S2EGZNQ.

fernandreu commented 4 years ago

And that's definitely appreciated, thanks!

fernandreu commented 4 years ago

I have made some changes to also detect groups of mutually exclusive attributes as part of the validation process. There are actually quite a few of those, mostly because of the getX ones (e.g. label and getLabel). You can see those groups here. The list might not be 100% correct yet, so there might be some false positives or undetected errors.

This build has these changes implemented.

GimmeChowder commented 4 years ago

Thanks for letting me know.

Al Sim Web Project Manager ValuSource

On 10/23/2020 2:42 PM, Fernando Andreu wrote:

I have made some changes to also detect groups of mutually exclusive attributes as part of the validation process. There are actually quite a few of those, mostly because of the |getX| ones (e.g. |label| and |getLabel|). You can see those groups here https://github.com/fernandreu/office-ribbonx-editor/blob/a56f842217ee7f60cd1e233be433e7405f88ffa2/src/OfficeRibbonXEditor/Helpers/Xml/XmlValidation.cs#L16. The list might not be 100% correct yet, so there might be some false positives or undetected errors.

This build https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=907&view=artifacts&type=publishedArtifacts has these changes implemented.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/114#issuecomment-715580154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARO3RRH5T5MGEQDVUOA33M3SMHTC5ANCNFSM4S2EGZNQ.