fernandreu / office-ribbonx-editor

An overhauled fork of the original Custom UI Editor for Microsoft Office, built with WPF
MIT License
516 stars 100 forks source link

Save changes prompt not working correctly #172

Closed jkpieterse closed 3 years ago

jkpieterse commented 3 years ago

I am using RibbonX editor (THANK YOU!) and found a small bug: If you have multiple (changed) files open and close the aopp, it only asks to save the active window. Changes in other windows are lost.

Version: 1.8.0.990 Runtime: .NET 5.0.7 Operating System: Microsoft Windows 10.0.19042

fernandreu commented 3 years ago

Hi @jkpieterse, thanks for letting me know, and sorry for the delay answering (I completely forgot). This was caused by the tool incorrectly applying the save action to the currently active document, instead of applying it to the document whose save changes dialog just appeared.

It should be fixed in this build: https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=1040&view=artifacts&pathAsName=false&type=publishedArtifacts

jkpieterse commented 3 years ago

Hi Fernando,

Thanks!

Not being familiar with that interface, which item do I need to get the installer?

Regards,

Jan Karel Pieterse

JKP Application Development Services

The Netherlands

Chamber of Commerce # 12052177

https://www.jkp-ads.com

Phone: +31 495 750546

Mobile: +31 648 628252

From: Fernando Andreu @.> Sent: maandag 26 juli 2021 22:27 To: fernandreu/office-ribbonx-editor @.> Cc: jkpieterse @.>; Mention @.> Subject: Re: [fernandreu/office-ribbonx-editor] Save changes prompt not working correctly (#172)

Hi @jkpieterse https://github.com/jkpieterse , thanks for letting me know, and sorry for the delay answering (I completely forgot). This was caused by the tool incorrectly applying the save action to the currently active document, instead of applying it to the document whose save changes dialog just appeared.

It should be fixed in this build: https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=1040 https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=1040&view=artifacts&pathAsName=false&type=publishedArtifacts &view=artifacts&pathAsName=false&type=publishedArtifacts

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/172#issuecomment-887003697 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBTBEFK7AP2WOR5MUP2URLTZXAJJANCNFSM5AGKJBIA .

fernandreu commented 3 years ago

There is a little button at the right which, if you press it, it will give you a download option:

image

(It's a little subtle yeah)

Feel free to download any of the variants in there. You should see one variant for each downloadable item which is usually available on a normal release (e.g. here) - plus a code coverage item that you can safely ignore.

jkpieterse commented 3 years ago

Hi Fernando,

Got it, thanks!

Regards,

Jan Karel Pieterse

JKP Application Development Services

The Netherlands

Chamber of Commerce # 12052177

https://www.jkp-ads.com

Phone: +31 495 750546

Mobile: +31 648 628252

From: Fernando Andreu @.> Sent: dinsdag 27 juli 2021 22:37 To: fernandreu/office-ribbonx-editor @.> Cc: jkpieterse @.>; Mention @.> Subject: Re: [fernandreu/office-ribbonx-editor] Save changes prompt not working correctly (#172)

There is a little button at the right which, if you press it, it will give you a download option:

https://user-images.githubusercontent.com/2480661/127223284-4167a3b0-ba97-483e-b327-a77691904186.png

(It's a little subtle yeah)

Feel free to download any of the variants in there. You should see one variant for each downloadable item which is usually available on a normal release (e.g. here https://github.com/fernandreu/office-ribbonx-editor/releases/tag/v1.8.0 ) - plus a code coverage item that you can safely ignore.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/172#issuecomment-887817453 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBTBEAYQMIATVT5PXEMGXLTZ4KF5ANCNFSM5AGKJBIA .