search

fernandreu / office-ribbonx-editor

An overhauled fork of the original Custom UI Editor for Microsoft Office, built with WPF
MIT License
513 stars 97 forks source link

Settings don't apply to tabs opened since the dialog was opened #197

Open fernandreu opened 2 years ago

fernandreu commented 2 years ago

Describe the bug If a tab was opened since the settings dialog was opened, any change in editor settings won't apply to it.

To Reproduce Steps to reproduce the behavior:

  1. Open settings
  2. While the settings dialog is still shown, open an editor tab
  3. Make changes to the editor settings: colors, font size, etc.
  4. Click on Apply / Accept
  5. The opened editor tab will look exactly as before

Expected behavior The changes in editor settings should be applied to any open editor tab, no matter when they were opened.

Additional context The changes apply if the editor tab is reopened or if the tool is restarted, so it is only a temporary issue. This occurs because the settings dialog holds a reference to all tabs opened but the latter isn't refreshed when it should.