editor crashes without a internet connection - Githubissues

fernandreu / office-ribbonx-editor

An overhauled fork of the original Custom UI Editor for Microsoft Office, built with WPF

MIT License

528 stars 104 forks source link

editor crashes without a internet connection #35

Closed juwens closed 5 years ago

juwens commented 5 years ago

Describe the bug editor crashes during start without a internet connection.

To Reproduce

Disconnect all internet connections
Start editor
client crashes immediately in VersionChecker.CheckVersionAsync
See error

Expected behavior Editor does not crash.

Additional context There can be other reasons for httpClient.GetAsync to fail:

github is down
connection timeout due to network or webserver weirdness
domain not resolved/blacklisted by your dns-server

pull request https://github.com/fernandreu/office-ribbonx-editor/pull/34

fernandreu commented 5 years ago

Fixed in 979ff81 (thanks again!)