fernandreu / office-ribbonx-editor

An overhauled fork of the original Custom UI Editor for Microsoft Office, built with WPF
MIT License
528 stars 104 forks source link

After clicking Save, Office RibbonX Editor closes and does not keep changes #55

Closed celiasja closed 5 years ago

celiasja commented 5 years ago

I am trying to create a custom ab in Excel

Steps: On Office RibbonX Editor:

  1. open an xlsm file
  2. insert Office Custom UI part (I've tried both 2007+ and 2010)
  3. insert sample XML > Excel A Custom Tab
  4. generate callbacks
  5. validate
  6. save

At this point, Office RibbonX Editor closes. No errors or warnings are displayed.

When opening the xlsm file in Excel no changes were made to the file or the ribbon.

I am using Windows 10 64 bit Office 365 64 bit

Any tip on how to solve this issue is very much appreciated. Thank you.

fernandreu commented 5 years ago

Hi celiasja,

It seems an unhandled exception is occurring that is causing the application to close unexpectedly. Unfortunately, I cannot reproduce the issue, and I cannot track the reason for this without seeing the actual exception. However, with a change I just made, the tool should show a message box with some details whenever this occurs, allowing you to continue with your work.

Could you give this new version a try and, if you now get an error message, let me know what it says? https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=455&view=artifacts

celiasja commented 5 years ago

Wow, Fernando! That’s what it’s called fast response! Thank you!

This is the message error that I got:

What do you think might be causing this? Could it be my Antivirus? I am using Bitdefender.

Thank you,

Celia Alves

Solve & Excel Consulting

https://solveandexcel.ca/ solveandexcel.ca | 1-647-882-6285

http://www.linkedin.com/in/celiajordaoalves Connect on LinkedIn | https://www.youtube.com/channel/UCzWFp4hOnIBHHCJi_SEWV7g YouTube | https://www.facebook.com/solveandexcel/ Facebook

From: Fernando Andreu notifications@github.com Sent: October 11, 2019 12:19 PM To: fernandreu/office-ribbonx-editor office-ribbonx-editor@noreply.github.com Cc: celiasja celia.alves.biz@gmail.com; Author author@noreply.github.com Subject: Re: [fernandreu/office-ribbonx-editor] After clicking Save, Office RibbonX Editor closes and does not keep changes (#55)

Hi celiasja,

It seems an unhandled exception is occurring that is causing the application to close unexpectedly. Unfortunately, I cannot reproduce the issue, and I cannot track the reason for this without seeing the actual exception. However, with a change I just made, the tool should show a message box with some details whenever this occurs, allowing you to continue with your work.

Could you give this new version a try and, if you now get an error message, let me know what it says? https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=455 https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=455&view=artifacts &view=artifacts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/55?email_source=notifications&email_token=ANOUTSOMM2VJZU5OSXCCRILQOCROLA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAPZUQ#issuecomment-541129938 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOUTSMU43PAKQ4ODB26RZ3QOCROLANCNFSM4I73CEIA . https://github.com/notifications/beacon/ANOUTSPREI55ZW2IRDAVT2LQOCROLA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAPZUQ.gif

celiasja commented 5 years ago

Another message:

I chose Yes on the message sent on my previous email. Then when closing, it said there were unsaved changes and asked if I wanted to save. I said Yes and got this error message.

This time I chose Yes again and the program closed.

As expected, no changes were made to the xlsm file.

Thank you,

Celia Alves

Solve & Excel Consulting

https://solveandexcel.ca/ solveandexcel.ca | 1-647-882-6285

http://www.linkedin.com/in/celiajordaoalves Connect on LinkedIn | https://www.youtube.com/channel/UCzWFp4hOnIBHHCJi_SEWV7g YouTube | https://www.facebook.com/solveandexcel/ Facebook

From: Celia Alves celia.alves.biz@gmail.com Sent: October 11, 2019 12:59 PM To: 'fernandreu/office-ribbonx-editor' reply@reply.github.com; 'fernandreu/office-ribbonx-editor' office-ribbonx-editor@noreply.github.com Cc: 'Author' author@noreply.github.com Subject: RE: [fernandreu/office-ribbonx-editor] After clicking Save, Office RibbonX Editor closes and does not keep changes (#55)

Wow, Fernando! That’s what it’s called fast response! Thank you!

This is the message error that I got:

What do you think might be causing this? Could it be my Antivirus? I am using Bitdefender.

Thank you,

Celia Alves

Solve & Excel Consulting

https://solveandexcel.ca/ solveandexcel.ca | 1-647-882-6285

http://www.linkedin.com/in/celiajordaoalves Connect on LinkedIn | https://www.youtube.com/channel/UCzWFp4hOnIBHHCJi_SEWV7g YouTube | https://www.facebook.com/solveandexcel/ Facebook

From: Fernando Andreu <notifications@github.com mailto:notifications@github.com > Sent: October 11, 2019 12:19 PM To: fernandreu/office-ribbonx-editor <office-ribbonx-editor@noreply.github.com mailto:office-ribbonx-editor@noreply.github.com > Cc: celiasja <celia.alves.biz@gmail.com mailto:celia.alves.biz@gmail.com >; Author <author@noreply.github.com mailto:author@noreply.github.com > Subject: Re: [fernandreu/office-ribbonx-editor] After clicking Save, Office RibbonX Editor closes and does not keep changes (#55)

Hi celiasja,

It seems an unhandled exception is occurring that is causing the application to close unexpectedly. Unfortunately, I cannot reproduce the issue, and I cannot track the reason for this without seeing the actual exception. However, with a change I just made, the tool should show a message box with some details whenever this occurs, allowing you to continue with your work.

Could you give this new version a try and, if you now get an error message, let me know what it says? https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=455 https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=455&view=artifacts &view=artifacts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/55?email_source=notifications&email_token=ANOUTSOMM2VJZU5OSXCCRILQOCROLA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAPZUQ#issuecomment-541129938 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOUTSMU43PAKQ4ODB26RZ3QOCROLANCNFSM4I73CEIA . https://github.com/notifications/beacon/ANOUTSPREI55ZW2IRDAVT2LQOCROLA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAPZUQ.gif

fernandreu commented 5 years ago

Hi Celia,

Sorry, I cannot see the pictures that (I assume) you posted. This is because GitHub removes them when the message gets added to the issue (here).

Could you upload them to some free service such as Imgur and pass me the links instead?

Regards, Fernando

celiasja commented 5 years ago

Thank you for letting me know, Fernando.

Please see this link: https://www.dropbox.com/s/h7ihrepmxyqhbvx/errorMsg.png?dl=0

I hope it works.

Thank you,

Celia Alves

From: Fernando Andreu notifications@github.com Sent: October 11, 2019 5:08 PM To: fernandreu/office-ribbonx-editor office-ribbonx-editor@noreply.github.com Cc: celiasja celia.alves.biz@gmail.com; Author author@noreply.github.com Subject: Re: [fernandreu/office-ribbonx-editor] After clicking Save, Office RibbonX Editor closes and does not keep changes (#55)

Hi Celia,

Sorry, I cannot see the pictures that (I assume) you posted. This is because GitHub removes them when the message gets added to the issue (here https://github.com/fernandreu/office-ribbonx-editor/issues/55 ).

Could you upload them to some free service such as Imgur https://imgur.com/upload and pass me the links instead?

Regards, Fernando

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/55?email_source=notifications&email_token=ANOUTSNQU75PWTE6R4HGE3TQODTKDA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBG4JQ#issuecomment-541224486 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOUTSPZHTA2HEPMGCA62DTQODTKDANCNFSM4I73CEIA . https://github.com/notifications/beacon/ANOUTSJW2DYHZ3P3C3SUMHLQODTKDA5CNFSM4I73CEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBG4JQ.gif

celiasja commented 5 years ago

I am sorry for such long posts. I have been responding directly from my email. The next time, I will come to anser directly here.

fernandreu commented 5 years ago

Hi Celia,

Thanks for the screenshots, and don't worry about the long posts!

The antivirus might have something to do, but I am more inclined to think it is a permissions issue with Windows (perhaps due to changes made by Dropbox).

I don't think the issue will be that the file is read-only because that does not give any error message (but it should; I will fix that). However, do you actually have write access to that file? I.e. if you check Properties -> Security for that file, does it show you something like this for your user?

image

That is the only way I found so far to replicate the exact same issue: removing the write permissions from myself.

If this is the case, one of the following should fix the issue:

From the tool side, there isn't anything I can do to fix the issue, but I will definitely try to detect this situation a bit better and have have a clearer error message when it occurs.

Regards, Fernando

celiasja commented 5 years ago

Hi Fernando!

The file access properties were ok. The System and I were both defined to have full access to the file. Dropbox was causing the issue. When I moded the file out of the Dropbox folder, Office RibbonX Edition stopped crashing on saving, and the changes were now kept on the file. So, thank you for that tip! Problem solved!

On another note, when adding a part for 2007, and then the XML code for an Excel Tab, the code generated comes with

When I click Validate, no error is reported. Then, opening the xlsm file, the ribbon was not there. I went back to the code and changed it to and the ribbon became visible. The old CustomUI Editor would notice that error on Validation. I am leaving a link for a video showing that in case you want to incorporate that in the next update: https://www.youtube.com/watch?time_continue=3&v=ZTt2FFyj2Fo Thank you so much for your quick and efficient support! Kudos to you!
fernandreu commented 5 years ago

Glad you found out the issue! Good catch about the XML namespace too. I have now added that check to the latest build (here). At some point, I will also try to adjust the template namespace automatically depending on the part where it is being inserted.

celiasja commented 5 years ago

Thank you, Fernando, for the fantastic service that you provide to the community.