search

fernshin22 / homework-responsive

0 stars 0 forks source link

Feedback on assignment 7 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #7 Project: Responsive Design

Description

Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.

Student: Fernanda Shin

Project URL: https://github.com/fernshin22/homework-responsive
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use media queries at a 780px breakpoint x
Content remains in appropriate divs, section, header etc. x
Content remains visible to the user (no side-scrolling) x
Fonts change size appropriately ( to please your eye) x
Margins and padding change size appropriately ( to please your eye) x
Content does not overlap x
In the blog section,modify grid-template-areas to have content appear in a different order on mobile than on desktop x
Show at least 2 conversions from px to em in your code x
TOTAL: 14/16
barryross commented 7 years ago

Hey Fernanda, great work on this assignment! Overall, this looks and works great!

I left off a mark for the "conversion" one, because while I realize you used em in your code, which is awesome, I was hoping to see some evidence of the actual conversion from px to em.

The other mark I left off was because I noticed the "Categories" and "Latest Posts" sections are not visible on mobile. While I realize this is not a "side-scrolling" issue, I thought this may have been unintentional, and felt important to point out with regards to content remaining visible. Can you please have a look and let me know if this was unintentional or not?

Please let me know if you have any questions about this!
Please see inline comments for more info and keep up the great work!