search

feroldi / cci

DEPRECATED PROJECT, see README
MIT License
37 stars 5 forks source link

review of the CMake files #27

Closed Sarcasm closed 6 years ago

Sarcasm commented 6 years ago

Hi,

You asked me on reddit if I could do a second round of review of the CMake files after you recent change here:

I didn't know how to comment the existing code on Github, so instead I made a pull request (PR). The PR can serve as a support for more discussion. Each commit focus on one thing, you will find some explanation in the commit message or in the code.

feroldi commented 6 years ago

This is really great work. Thanks for taking the time to reviewing! Appreciated.

Minor nitpick: on 38149cb , the standard states that main doesn't need to have a return statement, and if it's missing, then return 0 is assumed. But I understand if you say it may be not clear to others.

Sarcasm commented 6 years ago

TIL: http://eel.is/c++draft/basic.start.main#5

Thanks for letting me know. Still, I feel uncomfortable without a return statement. :)