feross / SpoofMAC

:briefcase: Change your MAC address for debugging
https://feross.org/spoofmac/
3.02k stars 271 forks source link

Split command when sending to subprocess.call on Linux platforms. #32

Closed anthonytw closed 9 years ago

anthonytw commented 9 years ago

On the Linux platform (tested on Ubuntu 14.04, but this probably affects other platforms as well) the subprocess.call routine expects the call and its arguments split in a list. Behavior when using the entire string is platform dependent (unlike when sending a list) and, in this case, causes an error when attempting to randomize the MAC. Behavior using a list is platform independent so should generally be preferred. This makes that change for the Linux platform.

feross commented 9 years ago

Thanks! Published new version as 1.2.2.

I'm looking for someone to make this work on Python 3. There are open PRs for this, but I don't have the cycles to evaluate them. @anthonytw Want to be a maintainer and evaluate these PRs?