Move back to let/const - Githubissues

feross / base64-js

New repo for ongoing work in https://github.com/beatgammit/base64-js (Base64 encoding/decoding in pure JS)

MIT License

14 stars 1 forks source link

Move back to let/const #1

Open ThatOneCalculator opened 4 months ago

ThatOneCalculator commented 4 months ago

It's 2024, I don't see why var should be used instead of the far more explicit let/const. https://github.com/feross/base64-js/commit/83f04b074694929d205171f48ad79a4e073e8429

jonkoops commented 4 months ago

Backwards compatibility is a reason. This would likely be a breaking change. I am definitely for it, as well as moving away from CommonJS to standardized ES modules, which would be a breaking change anyways.