search

feross / simple-get

Simplest way to make http get requests. Supports HTTPS, redirects, gzip/deflate, streams in < 100 lines
MIT License
401 stars 50 forks source link

Add gitignore update travis #40

Closed mcollina closed 6 years ago

mcollina commented 6 years ago

I've added a standard .gitignore and made the versions supported in .travis.yml explicit. I've also added 10 in .travis.yml.

feross commented 6 years ago

Personally, I'm not a fan of adding .gitignore to the repo. Surprised that you do that! I just use a global gitignore that applies to all projects https://github.com/feross/dotfiles/blob/master/.gitignore-global

If you insist, can we at least restrict it to realistic options like node_modules/ instead of the kitchen sink?

mcollina commented 6 years ago

@feross adding a .gitignore simplifies project maintenance and contribution :/. I've seen so many PRs with spurious files in there. Whatever is in gitignore it gets ignored by npm as well which is a huge bonus. (I keep a gazillion amount of files in every project folder - I tend to have more entries than the kitchen sink as well).

mcollina commented 6 years ago

I'll limit it to node_modules :).

mcollina commented 6 years ago

I've also added lock files.