feross / simple-get

Simplest way to make http get requests. Supports HTTPS, redirects, gzip/deflate, streams in < 100 lines
MIT License
401 stars 50 forks source link

Happy Eyeballs breaks simple-get if ipv6 times out #85

Open koush opened 2 months ago

koush commented 2 months ago

The underlying issue is that when dns resolves to multiple IPs all ips are attempted. ipv6 is tried first, then ipv4. This behavior is known as Happy Eyeballs. https://en.wikipedia.org/wiki/Happy_Eyeballs

node http now (v18 or v20?) tries both ipv6 and ipv4 addresses on requests.

For every ip connect timeout failure, it will emit a timeout event which simple-get interprets as an error and terminate the request (which is still attempting other ips). https://github.com/feross/simple-get/blob/e7a74115ca9dd28720f186275c5a67df81985426/index.js#L75 Specifically, disabling/ignoring this ipv6 timeout event in simple-get allows the request to succeed on ipv4, and prebuild-install completes successfully.

This timeout event handling may be a bug in either node (since the entire request hasnt timed out, just 1 ip attempt), or a bug in simple-get where it should be more discerning about which request timeout events it should observe. In any case, this is an issue with an end user machines ipv6 network configuration.

koush commented 2 months ago

I don't know how to reproduce this issue. It only happens on machines with a seemingly misconfigured or broken ipv6 router.

vweevers commented 2 months ago

Looks like this was a bug in node, fixed in https://github.com/nodejs/node/pull/47860.

koush commented 2 months ago

That does look familiar, but I'm seeing this behavior on node 20.13.1.