search

feross / zelda

Automatically `npm link` all your packages together!
MIT License
282 stars 32 forks source link

Fix symlink creation on Windows Issue #10 #11

Closed richard-bt closed 9 years ago

richard-bt commented 9 years ago

Fixes #10

On Windows 8.1 I was running in to an issue with the symbolic links created by Zelda.

Within my node_modules folder <package>.symlink files were being created instead of the expected folder symlinks.

Doing some searching led me to https://github.com/joyent/node/issues/2274, which pointed me towards the documentation here: https://nodejs.org/api/fs.html#fs_fs_symlink_srcpath_dstpath_type_callback

It looks like if on Windows specifying the type parameter 'dir' to fs.symlinkSync is necessary for the right kind of link to be created. For non-Windows platforms this type parameter is ignored.

feross commented 9 years ago

Thanks! Released as 2.4.2.