search

feroult / yawp

Kotlin/Java API framework for Google Appengine
http://yawp.io
MIT License
131 stars 19 forks source link

Add CORS parameters to web.xml #105

Closed LvlAndFarm closed 7 years ago

LvlAndFarm commented 7 years ago

Add 3 web.xml parameters for better CORS management (crossDomainOrigin, crossDomainHeaders, and crossDomainMethods). Requires web.xml parameter enableCrossDomain to be set to true

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 63.398% when pulling 5ba1111c04c356de77180f1b3782e1576b5f8aed on LvlAndFarm:master into 655965c556b96360b72df53c9a58ea4c7c251c0c on feroult:master.

feroult commented 7 years ago

@LvlAndFarm this is awesome! The only think is that it breaks backward compatibility. Would you mind to keep the default values from the previous version if a specific option is not set? It could be inside the CrossDomainParams class where you set the default values to null.

Thanks man!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 63.316% when pulling 09d99fb835d95f9431aafb3566d31bf117123b73 on LvlAndFarm:master into 655965c556b96360b72df53c9a58ea4c7c251c0c on feroult:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 63.244% when pulling 2221f143aa228c1bf2e5c173ad372b8696be424e on LvlAndFarm:master into 655965c556b96360b72df53c9a58ea4c7c251c0c on feroult:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 63.29% when pulling f2f6f424ede252e7ad301d2e7d02f38e9ae224f5 on LvlAndFarm:master into 655965c556b96360b72df53c9a58ea4c7c251c0c on feroult:master.

LvlAndFarm commented 7 years ago

I just fixed backwards compatibility and moved most of the logic to the CrossDomainManager