search

feroult / yawp

Kotlin/Java API framework for Google Appengine
http://yawp.io
MIT License
131 stars 19 forks source link

squid:S1166 - Exception handlers should preserve the original exception #86

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1166 - Exception handlers should preserve the original exception. This pull request removes technical debt of 170 minutes. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1166 Please let me know if you have any questions. George Kankava

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 65.735% when pulling ef16a31434e7a86733714b6f124a6f73fc5501cd on DevFactory:release/exception-handlers-should-preserve-the-original-exception-fix-1 into 4169f83ad360022dbe888783db1af9f8cc9a3d8a on feroult:master.

feroult commented 8 years ago

George, I think that those logs are not necessary, since most of the time we're passing the exception up. The exception is in the class ResourceFinder, witch is a copy from an external source, so I'm worried with it.

But thanks anyway :)