squid:S1143 - "return" statements should not occur in "finally" blocks

feroult / yawp

Kotlin/Java API framework for Google Appengine

http://yawp.io

MIT License

132 stars 20 forks source link

squid:S1143 - "return" statements should not occur in "finally" blocks #89

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1143 - "return" statements should not occur in "finally" blocks. This pull request removes 60 minutes of technical debt. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1143 Please let me know if you have any questions. George Kankava

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 65.831% when pulling ae87eddfaad368d10c2856ea7e8ee0db8cae8c59 on DevFactory:release/return-statements-in-finally-block-fix-1 into b74157093cb737c4e8ef2e3e23e2588490ef2d22 on feroult:master.

feroult commented 8 years ago

George,

This one changes the behaviour of the system. But thanks anyway.