ferranabello / Viperit

Viper Framework for iOS using Swift
MIT License
513 stars 66 forks source link

Apply SwiftLint #31

Closed buguibu closed 7 years ago

buguibu commented 7 years ago

First of all let me congratulate you, this is the best approach to VIPER I have seen and it's close to mine but using a bigger knowledge on Swift.

But it doesn't compile against https://github.com/realm/SwiftLint , i can exclude your Pod from the listing process but as i rather to understand your source would be cooler if it were linted.

Even excluding Pods from the linting, the modules generated by the template includes at least two lint errors that could be easily fixed:

buguibu commented 7 years ago

I have fix this on my fork you can take a look at it https://github.com/buguibu/Viperit , this is the first time I do source coda collaborations on a public repo so I really don't know how this work, so forgive me if do any nosense.

ferranabello commented 7 years ago

Hi @buguibu, thanks a lot for your comments!

I'll have a look at what you said. You can do a pull request with what you think it's best for code styling, and then we can discuss about those changes. If the changes are for the templates, you can fork this repo: https://github.com/ferranabello/ViperitTemplates

It's a good idea to have at least the templates linter compliant, so this framework is as plug-and-play as possible.

Again, thanks for helping out!

Cheers!

buguibu commented 7 years ago

I also have forked the templates repo and linted in a separate branch.