search

ferranbt / fastssz

Fast Ethereum2.0 SSZ encoder/decoder
MIT License
73 stars 44 forks source link

chore(sszgen): Remove redundant generated code #150

Closed letonchanh closed 4 months ago

letonchanh commented 4 months ago

In the generated code, when processing the last variable field in a container, we don't need to update the offset as there is no next variable field that uses the offset.

The PR also removes redundant statements in marshalContainer.

ferranbt commented 4 months ago

Hi! Thank you for the contribution.

Could you also run make build-spec-tests? To generate the code for the Ethereum consensus spec tests (CI fails without that).

letonchanh commented 4 months ago

Hi! Thank you for the contribution.

Could you also run make build-spec-tests? To generate the code for the Ethereum consensus spec tests (CI fails without that).

Sure. Thank you for the approval.