ferranbt / fastssz

Fast Ethereum2.0 SSZ encoder/decoder
MIT License
74 stars 44 forks source link

Fix hashing non-64-bit uints #27

Closed s1na closed 3 years ago

s1na commented 3 years ago

To stay consistent I added the PutUint methods to Hasher. But I also noticed MarshalUint methods are very similar. Do you think they can be re-used here?

ferranbt commented 3 years ago

It is okay to repeat those methods. They are used for distinct things with different "optimized" interfaces so I prefer not to change them that much for now. Thank you for the PR!