In this Pull Request, I have addressed an issue where the application could potentially hang indefinitely during the photo upscaling process.
Previously, the getUpscale function was invoked within a while loop without any timeout mechanism. If getUpscale persistently returned null (in cases where the upscaling process fails), the loop wouldn't terminate, causing the application to stay in waiting indefinitely.
To resolve this, I've introduced a startTime variable and a max_time_to_find_upscaled_link to create a maximum execution time for the upscaling process.
Now, when the getUpscale function fails to find a non-null upscaled_photo_url within the specified max_time_to_find_upscaled_link, it throws an Exception and gracefully exits, thereby allowing the rest of the application to continue its operation.
This change enhances the robustness of the application by ensuring that a setback in the upscaling process doesn't halt the completion of the entire script.
Add timeout to photo upscaling process
In this Pull Request, I have addressed an issue where the application could potentially hang indefinitely during the photo upscaling process.
Previously, the
getUpscalefunction was invoked within awhileloop without any timeout mechanism. IfgetUpscalepersistently returnednull(in cases where the upscaling process fails), the loop wouldn't terminate, causing the application to stay in waiting indefinitely.To resolve this, I've introduced a
startTimevariable and amax_time_to_find_upscaled_linkto create a maximum execution time for the upscaling process.Now, when the
getUpscalefunction fails to find a non-nullupscaled_photo_urlwithin the specifiedmax_time_to_find_upscaled_link, it throws an Exception and gracefully exits, thereby allowing the rest of the application to continue its operation.This change enhances the robustness of the application by ensuring that a setback in the upscaling process doesn't halt the completion of the entire script.