ferraridamiano / ConverterNOW

The Unit Converter app: easy, immediate and multi-platform
https://converter-now.web.app
GNU General Public License v3.0
391 stars 63 forks source link

[feature] Back Button pressed on Settings should open Sidebar #282

Closed skj-skj closed 3 weeks ago

skj-skj commented 8 months ago

Feature

When Back Button pressed or Swipe action for back is done on Settings it should show sidebar again.

Why?

on Android when I change settings I expect to use the conversion app and hoping back button will show me the default conversion screen or sidebar. but instead I get exited from the app.

it feels natural to press back button or swipe action for back when you are on setting page. for user pov the setting page is like stacked on the app and have to remove in order to go to previous page.

I have created this issue for setting but it can be expanded on the whole application for all conversion sections on sidebar.

ferraridamiano commented 3 months ago

I am aware of this issue. But it needs a fix from go_router / flutter side

Blocked by: https://github.com/flutter/flutter/issues/140869

Upvote that issue

ferraridamiano commented 3 weeks ago

This issue is now fixed with the latest commit. Unfortunately I used a workaround to make it work, the issue mentioned above still exists