Closed Dokotela closed 1 year ago
Base: 99.75% // Head: 99.77% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
8fc91b2
) compared to base (6382514
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @Dokotela and thank you for another wonderful PR! I'm going to review it and commit if needed! Don't worry too much about that calculations problem. Hope to finish the review today
Above recommendations should be fixed.
Reciprocal of molar mass isn't used in normal chemistry (at least I haven't seen it), but is used in medicine.
If a patient needs 12 mmol of something, and the medication comes in 3 mmol/gram, you need to order 4 grams. Obviously a simple example.
Perfect, thank you very much @Dokotela! I will soon publish a new release with all your new units!
Added new properties
I also added some more densities.
I've added tests for all of the above, but some of the conversion tests for MOLAR_VOLUME don't quite work the way I want them to. For instance: MOLAR_VOLUME.nanoMolesPerMilliLiter: 999999.9999999999 But should be: MOLAR_VOLUME.nanoMolesPerMilliLiter: 1000000
Any recommendations on where I went wrong?