Upgrade actix to v1, bump ipfs-api to v0.5.2

sameer commented 5 years ago

A bunch of things have changed with actix in v1 but I'm trying to avoid changing too much.

There was a crate re-org which required changing crate deps
The actix authors replaced failure with derive_more because actix errors are now !Send + !Sync so I had to do that here as well. I'm up for conditionally choosing derive_more or failure with cfg_if(hyper/actix), just thought it would make error.rs a lot longer.
From what I've seen, errors related to request-building are now delayed until the request is actually sent, at which time the future is instantly given an Err i.e. invalid URI.

ferristseng commented 5 years ago

The actix authors replaced failure with derive_more because actix errors are now !Send + !Sync so I had to do that here as well. I'm up for conditionally choosing derive_more or failure with cfg_if(hyper/actix), just thought it would make error.rs a lot longer.

This is pretty unfortunate, but I think we should support failure for hyper. #17 added failure, and I'm assuming people are still depending on that behavior. Everything else looks good though, thank you!

sameer commented 5 years ago

Ok, I've conditionally enabled failure derives for hyper. Turned out to be not as bad as I thought.

ferristseng commented 5 years ago

Thanks for making that change @sameer!

ferristseng / rust-ipfs-api

Upgrade actix to v1, bump ipfs-api to v0.5.2 #33