Preps for new release? - Githubissues

ferristseng / rust-ipfs-api

IPFS HTTP client in Rust

Apache License 2.0

247 stars 68 forks source link

Preps for new release? #37

Closed barabadzhi closed 4 years ago

barabadzhi commented 5 years ago

[x] Remove needless # from README
[x] Upgrade and specify exact dependencies to get 1-to-1 reproducible builds

barabadzhi commented 5 years ago

What do you think @ferristseng?

sameer commented 5 years ago

Why change the dependencies to exact requirements? Shouldn't that be the library user's choice through Cargo.lock & their own Cargo.toml?

barabadzhi commented 5 years ago

@sameer not exactly.

The user is not directly choosing versions of its dependencies' dependencies. Instead, if the version is loosely specified it can be shared on compilation stage. It provides minor advantage of possibly less size of the download, but can case collisions and regressions from time to time (rearly, if you are lucky).