search

ferristseng / rust-ipfs-api

IPFS HTTP client in Rust
Apache License 2.0
247 stars 68 forks source link

Added hyper-rustls feature #39

Closed akru closed 3 years ago

akru commented 4 years ago

Motivation

hyper-tls depends of native OpenSSL library that could be uncomfortable in some cases. In this PR I was added hyper-rustls feature that use Rust native implementation for TLS connections.

sameer commented 4 years ago

It might be better if neither is default and the choice is left to the API user. I've seen that actix-web and some other crates do this.

ferristseng commented 4 years ago

It might be better if neither is default and the choice is left to the API user.

Agreed, would prefer to keep both options open

akru commented 4 years ago

What’s about disabling TLS by default and making TLS implementation optionable?

ferristseng commented 4 years ago

Yeah, I think that's what I was imagining. Might be worth seeing how others do it like @sameer mentioned