ferristseng / rust-ipfs-api

IPFS HTTP client in Rust
Apache License 2.0
247 stars 68 forks source link

Only use POST for IPFS v0.5 compat #50

Closed cag closed 4 years ago

cag commented 4 years ago

Should fix #49

Edit: running this as a dependency for a graph-node and tests still not passing... not sure if something else is wrong about IPFS 0.5 compat, so putting this in draft form for now.

Edit 2: graph-node tests pass when using this changeset alongside IPFS v0.4.23. At the very least, this will make the library requests compatible with IPFS v0.5. There is some deeper semantic change that is causing tests to fail downstream, but this is outside the scope of this PR, so therefore, since these changes preserve compatibility with IPFS v0.4.23 but also gets rid of the 405 Method Not Allowed error that pops up when using GET with IPFS v0.5, this is no longer a draft request.

ferristseng commented 4 years ago

Looks great, thank you!