ferristseng
commented
3 years ago In practice, there's a small detail: the path parameter to ls is not actually optional, I don't know why it's an Option on IpfsClient::ls, and I'd prefer not to replicate that mistake. I've made it so the API doesn't break. If you want me to break IpfsClient::ls for consistency and correctnesses sake, please tell me.
Thanks for catching that mistake. I think just breaking the API is fine here for correctness sake.
Otherwise, looks great to me! I'll merge it when you make that change.
jcaesar
This adds options to
ipfs lsin the style of #54.In theory, this should be a no-brainer. In practice, there's a small detail: the path parameter to
lsis not actually optional, I don't know why it's anOptiononIpfsClient::ls, and I'd prefer not to replicate that mistake. I've made it so the API doesn't break. If you want me to breakIpfsClient::lsfor consistency and correctnesses sake, please tell me.(Btw, these are rather necessary to list large folders:
ipfs ls --stream --resolve-type=false --size=false /ipfs/bafybeicupvauz2urhyg7brbqy37z6ytorxmsog7uns6scntmd3cpvxfnyu/distfilesshould complete in about 20 minutes. Remove--streamand you just get no output for a very long time (but it does compelete). Remove the other two, too, and my node crashes. Though admittedly, folders with 10000s of items are rare.)