search

ferristseng / rust-ipfs-api

IPFS HTTP client in Rust
Apache License 2.0
246 stars 68 forks source link

PubSub v0.11.0 #94

Closed SionoiS closed 2 years ago

SionoiS commented 2 years ago

Hello!

This PR update the pubsub to go-ipfs v0.11.0

Makes #67 obsolete & Close #55 & #92

The Pubsub example works for 1 message then panic. IDK why... something to do with json deserialization in the request. Would need to be fixed before merging.

SionoiS commented 2 years ago

I changed pubsub message types. Deserialization now result in proper types for the various fields.

ferristseng commented 2 years ago

Thanks! Will try to find some time to test this myself.

I changed pubsub message types. Deserialization now result in proper types for the various fields.

Is that the reason for the failing test?

SionoiS commented 2 years ago

Can't be since it does work once then panic with the same message. Also, the panic is when sending the message, not receiving, which is even weirder.

I tried to find the problem but I'm stumped...

ferristseng commented 2 years ago

I made a PR to resolve the issue! Let me know if that fixes it.

Also added some comment. Lemme know when it's good for another review.

Thanks!

SionoiS commented 2 years ago

Let me know what you think!

ferristseng commented 2 years ago

Looks awesome! Thank you!