search

ferrous-systems / rust-training

Learning materials for the Rust Training courses by Ferrous Systems
127 stars 16 forks source link

Logo is borked when serving slides locally #134

Closed miguelraz closed 4 months ago

miguelraz commented 4 months ago

I get this

image

When running either httplz ./slides or the python server call.

The python script fortunately does print a 404:

❯ python3 -m http.server -d ./slides
Serving HTTP on :: port 8000 (http://[::]:8000/) ...
::1 - - [25/Feb/2024 13:44:39] "GET /overview.html HTTP/1.1" 200 -
::1 - - [25/Feb/2024 13:44:39] code 404, message File not found
::1 - - [25/Feb/2024 13:44:39] "GET /images/logo_ferrous-systems_rgb.png HTTP/1.1" 404 -

Opening up the slides from the released artifacts doesn't show up any problems, so I'm punting on this after the training, but still wanted to log it.

jonathanpallant commented 4 months ago

How did you build the HTML? I think the build.sh file copies over the images because mdslides does not.

miguelraz commented 4 months ago

Right, Windows doesn't work and I skipped that step. Manually doing it fixed it.

jonathanpallant commented 4 months ago

Ahh, we should maybe have a build.ps1 file. Or you could use WSL?

miguelraz commented 4 months ago

I bailed on learning powershell and started using nushell for everything, but yes, that would be a nice addition.