ferrous-systems / rust-training

Learning materials for the Rust Training courses by Ferrous Systems
127 stars 16 forks source link

Cargo, Crates, and Workspaces #43

Closed listochkin closed 1 year ago

listochkin commented 1 year ago
jonathanpallant commented 1 year ago

NB: Link to artefacts

jonathanpallant commented 1 year ago

Slide 10 didn't fit for me :/

image

jonathanpallant commented 1 year ago

Ah, the image doesn't work in the downloaded artefacts. This is because the book is placed in training-material-book.

I think we need to patch mdslides to find all the images and copy them to the output-dir. Or hack the build.sh file to cheat and cp ./book/*.{jpg,png} ./slides.

image

jonathanpallant commented 1 year ago

Great slide deck - tons of very useful content. As discussed in the call, you could break the "timing" slides off into another deck, or stick a break slide in front of them so it's clear where can stop if you don't have time (ha ha) for that section.

I also made a couple of minor suggestions, and other comments above.

jonathanpallant commented 1 year ago

I am approving this, based on the understanding that it's an optional slide that only groups that really want to deep dive into the build mechanics will get when asking for it.

I think all groups will at least need the introduction to workspaces, because the Connected DB uses a workspace.

jonathanpallant commented 1 year ago

Slide 10 is now good, but the image still doesn't appear. I suggest we just hack the build.sh file to copy over all the image it finds in the source directory into the HTML output folder.

jonathanpallant commented 1 year ago

Rebased on main so the FFI stuff compiles (my bad for accidentally pushing to main).