search

ferru97 / PyPaperBot

PyPaperBot is a Python tool for downloading scientific papers using Google Scholar, Crossref, SciHub, and SciDB.
MIT License
409 stars 77 forks source link

Duplicate page after changing IP #22

Closed kir-malishev closed 3 years ago

kir-malishev commented 3 years ago

Hello!

Is there any reason for this line to existing? Because of it, after changing the IP, the previous page is downloaded again.

https://github.com/ferru97/PyPaperBot/blob/a380ee00d67de88f189ccfe29da2ab30fc66c264/PyPaperBot/Scholar.py#L33

ferru97 commented 3 years ago

Hi!

Yes, it is actually superfluous to give that with the 'continue' it does not reach i + 1.

I saw that you are interested in the project, I don't know your programming skills (not that mine are excellent), but if you like I can add you as a contributor

Il giorno mar 23 mar 2021 alle ore 13:17 kir-malishev < @.***> ha scritto:

Hello!

Is there any reason for this line to existing? Because of it, after changing the IP, the previous page is downloaded again.

https://github.com/ferru97/PyPaperBot/blob/a380ee00d67de88f189ccfe29da2ab30fc66c264/PyPaperBot/Scholar.py#L33

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ferru97/PyPaperBot/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAQY5A5AGKTDFQZAHLHZELTFCBEJANCNFSM4ZVB4M5Q .

ferru97 commented 3 years ago

Solved

kir-malishev commented 3 years ago

Hi!

Now I am working on a small project under the direction of my supervisor, in which I need to programmatically search and process many scientific articles. Your library helped me a lot with this. I cannot promise to actively participate in the development of PyPaperBot, but I will try to contribute some.