ferrumc-rs / ferrumc

A reimplementation of the minecraft server in rust.
MIT License
1.07k stars 31 forks source link

Fix/keep alive stuff #128

Closed AnonymousBit0111 closed 1 week ago

AnonymousBit0111 commented 1 week ago

This PR kicks inactive players and remove them from the universe

Description Keep alives are now stored in the Incoming and Outgoing Keep alive packet, if the last incoming keep alive is not the same as the last outgoing one the client should be kicked and if a client fails to send a keep alive for 30 its also kicked, also now if it takes more than 2 seconds to read a packet the connection loop will skip to the next iteration to prevent the loop from hanging.

Motivation and Context This change was implemented to make sure inactive or invalid clients are kicked

How has this been tested? Ive connected to the server with two clients and disconnected them by turning off their internet, if I turn the interned back on within 30 seconds nothing happens, otherwise the client is kicked.

Screenshots (if appropriate): Types of changes

Checklist:

Sweattypalms commented 1 week ago

thanks bbg