ferventcoder / chocolatey-packages

The packages...all about the packages.
113 stars 112 forks source link

(anyvideoconverter) installer tries to open Edge to view thank you page; causes problem during installs #146

Open vxbush opened 8 years ago

vxbush commented 8 years ago

I use the Chocolatey MDT PowerShell wrapper to install multiple apps during an MDT OS deployment for Windows 10. When I install anyvideoconverter, the installation completes successfully--but it then tries to open a web browser to go to AVC's thank you page. At this point in the task sequence, it is running in the Administrator account and the default browser is Edge. The problem is, the administrator account isn't allowed to use Edge and a dialog box is put up by the OS and may stall the task sequence. You may not be able to continue the sequence until you close the dialog box.

It would be best for the installer not to allow the call to open the browser.

ferventcoder commented 8 years ago

@vxbush thanks for logging that! Just need to figure out how to AHK that. I know @dtgm had some ideas on this one.

ferventcoder commented 8 years ago

@vxbush as a bit of an explanation, hopefully there is something in the installer arguments that we can pass to make it completely silent - the call to the opening of the browser comes from the installer, sometimes those things are not completely silent like they should be.

Looks like InnoSetup is the installer - https://github.com/ferventcoder/chocolatey-packages/blob/11ca8201230535e51db9ea0a69faa4f7fd31eb22/automatic/anyvideoconverter/tools/chocolateyInstall.ps1#L4

dtgm commented 8 years ago

@ferventcoder https://gist.github.com/dtgm/9ac59fd8e5fb4c1e96c1cdb1f8330620

Waits on a window containing "Finish Installing Any Video Converter Free" so depends on HTML <title>Finish Installing Any Video Converter Free </title> and then verifies the URL is avclabs.com/any-video-converter-special.php

As it just closes the tab, if a user has any other tabs open the browser will remain open. It should work for any browser that use the typical hotkeys. I've been using it in a few packages for over a year now.