search

fervidus / secure_linux_cis

Apache License 2.0
16 stars 33 forks source link

add support for centos 8 / rhel 8 #20

Closed canihavethisone closed 4 years ago

canihavethisone commented 5 years ago

cis have recently published the benchmarks for centos 8 & rhel 8. I have just downloaded and will look at the changelogs tonight. My preference is to get centos in first.

Would be great to get this into the module.

canihavethisone commented 5 years ago

There is no changelog showing the differences between the Centos7 and 8 benchmarks in the CIS pdf. Therefore the differences will need to be manually compared.

My thought is to create a new parent class centos8.pp, which will include the centos7 subclasses which are the same for 8 and also the changes or additions that will be stored in a centos8 folder.

Does anyone have a different idea? One downside I can see is that we will effectively be referencing an earlier version for most of the new parent class, however this will avoid duplication.

An alternative method may be to implement module-level hiera, with a hiera.yaml that uses os.major fact to sort the differences. However this would require significant refactoring and may not even be entirely effective...

bjvrielink commented 5 years ago

For the Debian9 and Ubuntu18.04 support, I've re-used as much modules as possible. New or completely different benchmarks I've put into a manifests/debian9 folder, but if only minor changes (like e.g. the name of a package or file) were needed to make it work, I've adapted the existing redhat7 class with a case statement.

canihavethisone commented 5 years ago

ok, leave it with me. It may take a few weeks however. I am also updating another puppet project with the latest Windows 10 benchmark...